[Spice-devel] [PATCH spice-gtk] spice-common: update submodule

[Marc-André Lureau]

Hi

On Thu, Jan 17, 2019 at 1:11 PM Frediano Ziglio <fziglio at redhat.com> wrote:
>
> >
> > Hi
> >
> > On Thu, Jan 17, 2019 at 1:03 PM Frediano Ziglio <fziglio at redhat.com> wrote:
> > >
> > > >
> > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > >
> > >
> > > Maybe a comment saying that we want the merge to get the fix
> > > for Meson and big endian machines like s390x ?
> > >
> > > > $ git diff --submodule=log
> > > > Submodule subprojects/spice-common 924f47a..0a753b9:
> > > >   > meson: fix building for big-endian host
> > > >   > quic: fix sign-compare warning
> > > >   > build-sys: improve asciidoc rules to allow multiple targets
> > > >   > Add a .gitpublish
> > > >   > lz: More checks on image sizes
> > > >   > lz: Avoid buffer reading overflow checking for image type
> > > >   > test: Add a test for subject_to_x509_name function
> > > >   > marshaller: Provide spice_marshaller_fill_iovec for Windows
> > > >
> > >
> > > Usually the shortlog format is used for these commits
> > > (without the command), like
> >
> > Yes, I was looking for something slightly different, where the log is
> > shown in history order.
> >
> > I wanted to share the command I used, since I just learned about it.
> >
> > ack?
> >
>
> I personally like the shortlog format, it would just confuse people
> using git log on spice-common.

Ok, I don't mind, but I don't think we should be so strict about
submodule update commit message. If you want the details, you better
look at the git log..

Fwiw, there is also:

$ git submodule summary
* subprojects/spice-common 924f47a...0a753b9 (8):
  > meson: fix building for big-endian host
  > quic: fix sign-compare warning
  > build-sys: improve asciidoc rules to allow multiple targets
  > Add a .gitpublish
  > lz: More checks on image sizes
  > lz: Avoid buffer reading overflow checking for image type
  > test: Add a test for subject_to_x509_name function
  > marshaller: Provide spice_marshaller_fill_iovec for Windows



>
> > >
> > >     Update spice-common submodule
> > >
> > >     This brings in the following changes:
> > >
> > >     Christophe Fergeau (20):
> > >           build: Update git.mk to latest version
> > >           build: Remove docs/.gitignore
> > >           build: Add __pycache__/*.pyc to DISTCLEANFILES
> > >           log: Only install glib log handler if SPICE_DEBUG_LEVEL is set
> > >           test-logging: Improve debug level tests
> > >           test-region: Use GTest API
> > >           test-region: Replace direct printf with g_debug() calls
> > >           test-region: Don't call region_dump() by default
> > >
> > >
> > > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > ---
> > > >  subprojects/spice-common | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/subprojects/spice-common b/subprojects/spice-common
> > > > index 924f47a..0a753b9 160000
> > > > --- a/subprojects/spice-common
> > > > +++ b/subprojects/spice-common
> > > > @@ -1 +1 @@
> > > > -Subproject commit 924f47a653bd87fbd50229ee34b58d7b9a3f1ec8
> > > > +Subproject commit 0a753b93b50b548a2ac04023c96a7cda83f204bf
> > >
>


-- 
Marc-André Lureau