[Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

Snir Sheriber ssheribe at redhat.com
Mon Jan 21 11:45:31 UTC 2019


On 1/21/19 12:21 PM, Frediano Ziglio wrote:
>> Hi,
>>
>> Just came to me that it may fail if HAVE_LIBVA is not defined && version
>> is >1.14 and so i checked and
>> it seems to work also without the context handling, Is it possible that
>> application's context handling is
>> not needed? I couldn't find any related vaapisink bug that was closed
>> recently.
>>
>> Snir.
>>
> It crashed for me. Are you sure code is using vaapisink? Print the


Yes, first thing I've check, see dot file attached ( I just revert this 
patch and comment out the vaapisink ranking)

After additional check, It seems to stop crashing for me since the 
overlay control was moved to the widget.


Snir.

> pipeline, sometimes code is using vaapi but not the sink (so Gstreamer
> extracts textures and then use xv plugin for instance).
>
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: spice-gtk-gst-pipeline-debug-0-h264.dot
Type: application/msword-template
Size: 37582 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190121/abfe63a4/attachment-0001.bin>


More information about the Spice-devel mailing list