[Spice-devel] [PATCH spice-gtk v7] Fix overlay for vaapisink

[Snir Sheriber]

On 1/21/19 2:04 PM, Frediano Ziglio wrote:
>> On 1/21/19 12:21 PM, Frediano Ziglio wrote:
>>>> Hi,
>>>>
>>>> Just came to me that it may fail if HAVE_LIBVA is not defined && version
>>>> is >1.14 and so i checked and
>>>> it seems to work also without the context handling, Is it possible that
>>>> application's context handling is
>>>> not needed? I couldn't find any related vaapisink bug that was closed
>>>> recently.
>>>>
>>>> Snir.
>>>>
>>> It crashed for me. Are you sure code is using vaapisink? Print the
>>
>> Yes, first thing I've check, see dot file attached ( I just revert this
>> patch and comment out the vaapisink ranking)
>>
>> After additional check, It seems to stop crashing for me since the
>> overlay control was moved to the widget.
>>
> Which exact patch(es) ?


It's crashing before 8c5bf5dedab3cd5a9c7ac484c0d97d43aeb0056b

If i comment out vaapisink avoidance

> Maybe some minor changes did the trick ?


It is working on upstream + the attached patch


> I cannot see the reason why moving code from one side to another
> would have fix the issue, would be different if the initialization
> would be done at library (spice-glib) initialization but it's done
> lately when the stream arrive so after all libraries are initialized.


It's indeed weird, btw pipelines are identical in both cases


>
>> Snir.
>>
>>> pipeline, sometimes code is using vaapi but not the sink (so Gstreamer
>>> extracts textures and then use xv plugin for instance).
>>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-Fix-overlay-for-vaapisink-and-allow-vaapisink.patch
Type: text/x-patch
Size: 6245 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190121/341b1cb9/attachment.bin>