[Spice-devel] [PATCH linux vdagent v5 0/7] Use the PCI addr and display ID

[Lukáš Hrázký]

For the series:

Acked-by: Lukáš Hrázký <lhrazky at redhat.com>


On Wed, 2019-01-23 at 16:18 -0600, Jonathon Jongsma wrote:
> This is a patch set that handles the PCI address and device dispay ID
> sent down to the agent by the server, and uses that to maintain a map
> for looking up a particular xrandr output for a given spice display id.
> 
> This patch series builds on the patch from Lukas titled "Receive the
> graphics_device_info message".
> 
> Changes in v5:
>  - more line length changes
>  - squashed last several patches into one
> 
> Changes in v4:
>  - rebased on Lukas's latest patch
>  - Added a new commit that fixes the cursor when using with mjpeg streaming.
>  - various small fixes from previous reviews (e.g. line length, etc)
> 
> Changes in v3:
>  - Fixed a bug where the X Display was not set properly and caused a
>    crash
>  - moved call to vdagent_x11_send_daemon_guest_xorg_res() to outside the
>    loop to avoid sending multiple times when more than one device is
>    received. (Patch 9)
> 
> Changes in v2:
>  - Removed some ACKed and merged patches
>    - Fix typo in comment
>    - Fix confusion between output index and crtc index
>  - added a patch to send new display IDs when device info changes
>  - multiple changes from review
>    - factored out function find_device_at_pci_address()
>    - No more initializing X/XRandr
>    - removed goto
>    - improved logging
>    - etc.
> 
> 
> Jonathon Jongsma (7):
>   Add lookup_xrand_output_for_device_info()
>   Look up and store xrandr output in display map
>   Make clearer distinctions between output ids
>   Use guest output map to determine xrandr output
>   Factor a function out of get_current_mon_config()
>   Use new function in vdagent_x11_send_daemon_guest_xorg_res()
>   Send display_id down to the vdagentd daemon
> 
>  Makefile.am               |  14 ++
>  configure.ac              |   1 +
>  src/vdagent/device-info.c | 506 ++++++++++++++++++++++++++++++++++++++
>  src/vdagent/device-info.h |  30 +++
>  src/vdagent/x11-priv.h    |   2 +-
>  src/vdagent/x11-randr.c   | 348 +++++++++++++++++---------
>  src/vdagent/x11.c         |  20 +-
>  src/vdagentd-proto.h      |   1 +
>  src/vdagentd/uinput.c     |  23 +-
>  tests/test-device-info.c  | 262 ++++++++++++++++++++
>  10 files changed, 1073 insertions(+), 134 deletions(-)
>  create mode 100644 src/vdagent/device-info.c
>  create mode 100644 src/vdagent/device-info.h
>  create mode 100644 tests/test-device-info.c
>