[Spice-devel] [PATCH spice-common] Remove obsolete Autoconf macros

[Christophe Fergeau]

On Wed, Jan 30, 2019 at 09:19:08AM +0000, Frediano Ziglio wrote:
> Autoconf 2.63 was released on September 2008.

It's not really a matter of when this was released, what matters is what
version the distros we care about have. As far as I remember, this was
needed on el6, but these days it has 2.63, and anyway spice configure.ac
has more issues on el6, so we have to generate the configure script on a
newer distro.
However, it seems it would have been true also when the compat macros
were added, so not fully clear to me why they are here :)

Acked-by: Christophe Fergeau <cfergeau at redhat.com>




> These simple macros conflict with system ones and can
> causes issues with some systems (currently MacOS).
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  m4/spice-deps.m4 | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> index 7f977278..02230ddd 100644
> --- a/m4/spice-deps.m4
> +++ b/m4/spice-deps.m4
> @@ -1,11 +1,3 @@
> -# For autoconf < 2.63
> -m4_ifndef([AS_VAR_APPEND],
> -          AC_DEFUN([AS_VAR_APPEND], $1=$$1$2))
> -m4_ifndef([AS_VAR_COPY],
> -          [m4_define([AS_VAR_COPY],
> -          [AS_LITERAL_IF([$1[]$2], [$1=$$2], [eval $1=\$$2])])])
> -
> -
>  # SPICE_WARNING(warning)
>  # SPICE_PRINT_MESSAGES
>  # ----------------------
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190130/201ca5f1/attachment.sig>