[Spice-devel] [PATCH spice-gtk v3 0/3] Implementation of USB backend layer

[Victor Toso]

Hi,

On Wed, Jul 10, 2019 at 03:22:38PM +0200, Victor Toso wrote:
> Hi,
> 
> On Wed, Jul 10, 2019 at 10:49:21AM +0100, Frediano Ziglio wrote:
> > This layer communicates with libusb and libusbredir and
> > provides the API for all the operations related to USB
> > redirection. All other modules of spice-gtk communicate
> > only with usb backend instead of calling libusb and
> > usbredirhost directly.
> > This is prerequisite of further implementation of
> > cd-sharing via USB redirection
> 
> Looks good. I plan to do further test tomorrow morning and push,
> if no one else complains.
> 
> Thanks and sorry for taking quite long time to merge this.

Tested with windows 10 and Fedora 29 guests. Seems to work fine.
Debug is a bit verbose but should be fine till we get CD-ROM
redirection patches in. I plan to work on some cleanup on
usbredir stack as discussed earlier but I don't want that or
minor changes to prevent further work on CD-ROM redir feature.

I'll be pushing this now.

Cheers,
Victor

> 
> Cheers,
> Victor
> 
> > 
> > Changes from v2: rebased on master
> > 
> > Changes from v1: cosmetic changes per v1 review
> > Added a rebased patch (3) from Frediano Ziglio
> > For the increment see
> > https://gitlab.freedesktop.org/yuri_benditovich/spice-gtk/commits/backend2-increment
> > 
> > Yuri Benditovich (3):
> >   usb-redir: isolate usage of libusb and usbredirhost
> >   usb-redirection: do not duplicate USB device properties
> >   usb-device-manager: Define _SpiceUsbDevice instead of
> >     SpiceUsbDeviceInfo
> > 
> >  src/channel-usbredir-priv.h   |  12 +-
> >  src/channel-usbredir.c        | 236 ++----------
> >  src/meson.build               |   2 +
> >  src/usb-backend.c             | 657 ++++++++++++++++++++++++++++++++++
> >  src/usb-backend.h             | 102 ++++++
> >  src/usb-device-manager-priv.h |   1 -
> >  src/usb-device-manager.c      | 397 +++++++-------------
> >  src/win-usb-dev.c             | 103 ++----
> >  src/win-usb-dev.h             |   5 +-
> >  9 files changed, 967 insertions(+), 548 deletions(-)
> >  create mode 100644 src/usb-backend.c
> >  create mode 100644 src/usb-backend.h
> > 
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190711/0ff78606/attachment.sig>