[Spice-devel] [PATCH x11spice v2] Fix hang when launching with invalid config
Frediano Ziglio
fziglio at redhat.com
Mon Jul 15 08:11:21 UTC 2019
>
> When launching with no config file or arguments, the "You must provide
> some authentication method" dialog appears. Clicking the Close button
> would hang the application and it would never quit.
>
> s->draw_command_in_progress was uninitialized, and flush_and_lock()
> would get stuck in an infinite loop waiting for it to be 0.
>
> Initialize the entire session struct to 0.
>
> Signed-off-by: Brendan Shanks <bshanks at codeweavers.com>
Acked
> ---
> src/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/main.c b/src/main.c
> index 5dde233..7f321af 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -63,6 +63,8 @@ int main(int argc, char *argv[])
> int session_created = 0;
> int session_started = 0;
>
> + memset(&session, 0, sizeof(session));
> +
> /*------------------------------------------------------------------------
> ** Parse arguments
> **----------------------------------------------------------------------*/
Frediano
More information about the Spice-devel
mailing list