[Spice-devel] [PATCH spice-server 3/3] ci: Add some Valgrind suppressions for Fedora 30

[Uri Lublin]

On 7/18/19 10:32 AM, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Hi Frediano,

I've been playing with it too.
Had similar rules but different.

Your version works for me.
Some minor comments below.

> ---
>   server/tests/valgrind/spice.supp | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
> index 1bfe81006..dd3663c68 100644
> --- a/server/tests/valgrind/spice.supp
> +++ b/server/tests/valgrind/spice.supp
> @@ -36,3 +36,28 @@
>   	...
>   	fun:p11_kit_modules_load
>   }
> +
> +{
> +	gnutls_x509_ext_import_subject_alt_names
> +	Memcheck:Cond
> +	...
> +	fun:gnutls_x509_ext_import_subject_alt_names
> +	fun:gnutls_x509_crt_import
> +	fun:gnutls_x509_trust_list_iter_get_ca
> +	...
> +	fun:g_initable_new_valist
> +	fun:g_initable_new
> +	...

possibly you can remove the last 4 lines (not important)

> +}
> +
> +{
> +	glib_g_socket_client_class_init

Are all glib sockets leaking when initialized ?

> +	Memcheck:Leak
> +	fun:calloc
> +	...
> +	fun:type_class_init_Wm
> +	...
> +	fun:g_socket_client_class_init
> +	...
> +	fun:type_class_init_Wm

You can probably remove the type_class_init_Wm and ...

Uri.