[Spice-devel] [PATCH phodav 1/2] spice: read_thread: return number of read bytes on EOF

[Victor Toso]

Hi,

On Mon, Jul 22, 2019 at 03:22:10PM +0200, Jakub Janků wrote:
> We already check with each input_stream_read_thread_finish()
> whether the count of the read bytes matches the requested one.
> 
> Also, this is the way GLib handles it.
> 
> Signed-off-by: Jakub Janků <jjanku at redhat.com>
> ---
> 
> https://gitlab.gnome.org/GNOME/phodav/merge_requests/4
> 
> I've opened the merge request on gitlab some time ago,
> so now I'm sending it here as a form of ping.

Arg, missed. I'm now 'Watching' Phodav project to get
notifications. Thanks for the ping, patches looks fine and now
merged.

> ---
>  spice/spice-webdavd.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
> index f814890..81b4d91 100644
> --- a/spice/spice-webdavd.c
> +++ b/spice/spice-webdavd.c
> @@ -180,10 +180,6 @@ read_thread (GTask *task,
>        g_debug ("error: %s", error->message);
>        g_task_return_error (task, error);
>      }
> -  if (bread != data->count)
> -    {
> -      g_task_return_int (task, -1);
> -    }
>    else
>      {
>        g_task_return_int (task, bread);
> -- 
> 2.21.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190723/e3ceb063/attachment.sig>