[Spice-devel] [spice-gtk v2 0/9] usb-redir: unification of Linux and Windows code

Victor Toso victortoso at redhat.com
Tue Jul 23 13:50:52 UTC 2019


Hi,

Thanks for the split, the difference for review is like the
difference between day and night.

1/9 is already merged but I'll merge 2/9 to 5/9 so it'll reduce
the amount of patches to send.

Cheers,

On Tue, Jul 23, 2019 at 10:26:59AM +0300, Yuri Benditovich wrote:
> This series is dedicated to unification of Linux Windows flows
> in usb-device-manager. It moves differences related to libusb
> to USB backend module and simplifies implementation of procedures
> related to USB redirection.
> 
> Yuri Benditovich (9):
>   build: require minimal libusb version 1.0.21
>   usb-redir: move 3 static procedures up for further reuse
>   usb-redir: split fill_usb_info procedure for further reuse
>   usb-redir: change parameter name 'bdev' to 'dev'
>   usb-redir: cosmetic changes in hotplug_callback
>   usb-redir: unify device hotplug/unplug for Windows and Linux
>   usb-redir: pass GError to hotplug registration procedure
>   usb-redir: move USB events handling to USB backend
>   usb-redir: use g_thread_try_new instead of g_thread_new
> 
>  meson.build                   |   4 +-
>  src/channel-usbredir.c        |  28 ---
>  src/meson.build               |   4 +-
>  src/usb-backend.c             | 419 ++++++++++++++++++++++----------
>  src/usb-backend.h             |  13 +-
>  src/usb-device-manager-priv.h |   6 -
>  src/usb-device-manager.c      | 139 +----------
>  src/win-usb-dev.c             | 436 ----------------------------------
>  src/win-usb-dev.h             |  84 -------
>  9 files changed, 301 insertions(+), 832 deletions(-)
>  delete mode 100644 src/win-usb-dev.c
>  delete mode 100644 src/win-usb-dev.h
> 
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190723/5932e699/attachment-0001.sig>


More information about the Spice-devel mailing list