[Spice-devel] [PATCH x11spice v2 0/3] Add cache for SHM segments

Brendan Shanks bshanks at codeweavers.com
Thu Jul 25 18:43:49 UTC 2019


> On Jul 16, 2019, at 7:16 PM, Brendan Shanks <bshanks at codeweavers.com> wrote:
> 
> Add a cache to x11spice for SHM segments.
> 
> v2 should address Frediano's comments: style, use of G_N_ELEMENTS,
> using unsigned types for width/height/size, creating a separate struct
> to hold all the segment-specific variables, and reducing traversals of
> the cache.
> 
> Brendan Shanks (3):
>  Use unsigned int/size_t for display width/height/buffer size
>  Create separate shm_segment_t struct for SHM segments
>  Add cache for SHM segments
> 
> doc/spice_indent |   1 +
> src/display.c    | 209 ++++++++++++++++++++++++++++++++++++++++-------
> src/display.h    |  25 ++++--
> src/scan.c       |   2 +-
> src/session.c    |   2 +-
> src/spice.c      |   2 +-
> 6 files changed, 200 insertions(+), 41 deletions(-)
> 
> -- 
> 2.17.1
> 

Frediano and others,

Do you have any feedback for these patches?

Brendan


More information about the Spice-devel mailing list