[Spice-devel] [PATCH spice-server] common-graphics-channel: Avoid closing server if client send huge messages

[Victor Toso]

Hi,

On Mon, Jun 03, 2019 at 08:39:30AM +0100, Frediano Ziglio wrote:
> The Cursor/DisplayChannel is not expecting large messages (which are
> protocol violations).
> 
> This fixes https://gitlab.freedesktop.org/spice/spice-server/issues/11.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Sure,
Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  server/common-graphics-channel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/common-graphics-channel.c b/server/common-graphics-channel.c
> index 92349ce4d..cea805d09 100644
> --- a/server/common-graphics-channel.c
> +++ b/server/common-graphics-channel.c
> @@ -53,7 +53,7 @@ static uint8_t *common_alloc_recv_buf(RedChannelClient *rcc, uint16_t type, uint
>      }
>  
>      if (size > CHANNEL_RECEIVE_BUF_SIZE) {
> -        spice_critical("unexpected message size %u (max is %d)", size, CHANNEL_RECEIVE_BUF_SIZE);
> +        spice_warning("unexpected message size %u (max is %d)", size, CHANNEL_RECEIVE_BUF_SIZE);
>          return NULL;
>      }
>      return common->priv->recv_buf;
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190610/636cce38/attachment.sig>