[Spice-devel] [client 1/5] gstreamer: Avoid direct access to GQueue fields

Francois Gouget fgouget at codeweavers.com
Sat Jun 15 00:14:42 UTC 2019


On Fri, 14 Jun 2019, Frediano Ziglio wrote:

> > 
> > Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> 
> Considering that the field is public and that code will get 
> slower and bigger at least would be good to describe the reason
> why you consider it better.

Consistency mostly. This is the only place where we access the GQueue 
fields. In other places we use g_queue_peek_head_link() instead of 
decoding_queue->head for instance.

But I'm fine with keeping decoding_queue->length if that's preferred.

-- 
Francois Gouget <fgouget at codeweavers.com>


More information about the Spice-devel mailing list