[Spice-devel] [client v2 06/12] channel-display: Rename the frame mmtime variables

[Francois Gouget]

On Tue, 18 Jun 2019, Frediano Ziglio wrote:

> > > 
> > > The point of the mmtime timestamps is that they are the same on the
> > > server and client thanks to the client running its own mmtime clock
> > > synchronized, modulo a server-controlled offset, to the server's
> 
> Not sure about the "modulo a server-controlled offset", I would
> say "biased by a server-controlled offset".

I'm ok with the wording change.


> > > mmtime clock.
> > > So the frame mmtime timestamps are neither tied to the server nor the
> > > client. They are however tied to the frame.
> > 
> > I got to read this last paragraph couple of times to make it sounds right,
> > but I don't have suggestions.

Maybe:

Thus prefixing mmtime variable names with client or server does 
not really make sense so it is better to use the prefix to indicate 
what they are related to such as the frame or the current time.


[...]
> > -                                      guint32 server_mmtime,
> > -                                      guint32 client_mmtime)
> > +                                      guint32 frame_mmtime,
> > +                                      guint32 current_mmtime)
[...]

-- 
Francois Gouget <fgouget at codeweavers.com>