[Spice-devel] [PATCH spice-streaming-agent 2/2] gst-plugin: Use autovideoconvert element for color space conversion

[Frediano Ziglio]

> 
> When vaapi based encoder is used it's likely that also vaapi based
> conversion is available (using the vaapipostproc element).
> Moving to autovideoconvert will automatically choose a suitable
> convert element according to elements availability (e.g. in the
> vaapi case it would select vaapipostproc due to its high rank).
> 
> Signed-off-by: Snir Sheriber <ssheribe at redhat.com>

Really minor: vaapi -> VAAPI ?

Acked-by: Frediano Ziglio <fziglio at redhat.com>

> ---
> At first i had a patch to choose vaapipostproc manually but then i remembered
> this element
> which suppose to do it automatically (it seems vaapipostproc has high enough
> rank). I think
> it's preferred although it's in gst-plugins-bad
> ---
>  src/gst-plugin.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
> index cf660eb..d8e2d89 100644
> --- a/src/gst-plugin.cpp
> +++ b/src/gst-plugin.cpp
> @@ -215,7 +215,7 @@ void GstreamerFrameCapture::pipeline_init(const
> GstreamerEncoderSettings &settin
>      if (!capture) {
>          throw std::runtime_error("Gstreamer's capture element cannot be
>          created");
>      }
> -    GstObjectUPtr<GstElement>
> convert(gst_element_factory_make("videoconvert", "convert"));
> +    GstObjectUPtr<GstElement>
> convert(gst_element_factory_make("autovideoconvert", "convert"));
>      if (!convert) {
>          throw std::runtime_error("Gstreamer's 'videoconvert' element cannot
>          be created");

Change 'videoconvert' to 'audiovideoconvert' here?

>      }

Frediano