[Spice-devel] [PATCH win-vdagent v2] Don't exit when receiving unknown messages

Jonathon Jongsma jjongsma at redhat.com
Mon Mar 4 19:53:16 UTC 2019


In 8251fa25, a check on the minimum size of a message was introduced.
For unsupported messages, the vdagent simply exited. This makes it
inconsistent with previous behavior and inconsistent with the behavior
of the linux vdagent.  Instead, just print a warning indicating that an
unsupported message was received and ignore it.

Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
---
changes in v2:
 - change rationale in commit log

 vdagent/vdagent.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index 89019bb..177e663 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -1288,8 +1288,7 @@ void VDAgent::dispatch_message(VDAgentMessage* msg, uint32_t port)
         break;
     }
     if (min_size < 0) {
-        vd_printf("Unsupported message type %u size %u", msg->type, msg->size);
-        _running = false;
+        vd_printf("Unsupported message type %u size %u, ignoring", msg->type, msg->size);
         return;
     }
     if (msg->size < (unsigned) min_size) {
-- 
2.17.2



More information about the Spice-devel mailing list