[Spice-devel] [PATCH spice-common 8/9] protocol: Add a dummy TunnelChannel

[Frediano Ziglio]

> 
> On 3/3/19 9:10 PM, Frediano Ziglio wrote:
> > The removal of the channel definition will cause the enumeration
> > to miss this old channel.
> > Add a dummy channel (empty) to avoid having to update spice-gtk
> > and spice-server and possibly breaking other software.
> 
> Hi Freidano,
> 
> This patch should be applied earlier, such that nothing
> breaks when previous patches are applied.
> 
> Looks good to me.
> 
> Uri.
>

The generation of enums.h in spice-protocol is not automatic,
so nu rush.

Acked?
 
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >   spice.proto | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/spice.proto b/spice.proto
> > index de80b27..1f9f57b 100644
> > --- a/spice.proto
> > +++ b/spice.proto
> > @@ -1235,6 +1235,9 @@ channel RecordChannel : BaseChannel {
> >       } @declare start_mark;
> >   };
> >   
> > +channel TunnelChannel {
> > +};
> > +
> >   enum32 vsc_message_type {
> >       Init = 1,
> >       Error,
> > @@ -1357,8 +1360,8 @@ protocol Spice {
> >       CursorChannel cursor;
> >       PlaybackChannel playback;
> >       RecordChannel record;
> > -    // there used to be a TunnelChannel
> > -    SmartcardChannel smartcard = 8;
> > +    TunnelChannel tunnel;
> > +    SmartcardChannel smartcard;
> >       UsbredirChannel usbredir;
> >       PortChannel port;
> >       WebDAVChannel webdav;
> > 
> 
>