[Spice-devel] [spice-gtk v2 1/2] Deprecate “color-depth” properties

[Christophe Fergeau]

Hey,

On Wed, Mar 06, 2019 at 02:24:24PM +0000, Victor Toso wrote:
> Hi,
> 
> On Tue, Jan 08, 2019 at 04:22:55PM +0100, Victor Toso wrote:
> > Hi,
> > 
> > On Tue, Jan 08, 2019 at 04:09:54PM +0100, Christophe Fergeau wrote:
> > > On Fri, Dec 14, 2018 at 04:29:46PM +0100, Victor Toso wrote:
> > > > From: Victor Toso <me at victortoso.com>
> > > > 
> > > > With commit 1a980f3712 we deprecated some command line options. The
> > > > color-depth one is the only one which is not used for testing/debug
> > > > purposes.
> > > > 
> > > > The intention of this option is to set guest's video driver color
> > > > configuration, currently only windows guest agent uses this feature up
> > > > to Windows 7. Windows 8 and up, setting color depth below 32 would
> > > > fail. We should not encourage the usage of this feature.
> > > > 
> > > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1543538
> > > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1350853
> > > > 
> > > > This patch deprecates both SpiceMainChannel::color-depth and
> > > > SpiceSession::color-depth while ignoring any set/get to it.
> > > > 
> > > > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > > > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > > 
> > > Still fine with me, though it's indeed a good question that Uri raised,
> > > whether we want to keep this alive a bit longer for win7 since it's
> > > still supported by MS.
> > 
> >   | Microsoft ended mainstream support for Windows 7 on January 13,
> >   | 2015, but extended support won't end until January 14, 2020.
> > 
> > Oh well, IMHO we could remove it for 0.36 but we can do it for
> > after 0.36 as well.
> 
> Now that 0.36 is out, I'm wondering if this two patches are fine
> for you? CC: teuf and Uri :)

Fine with me,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190307/f6508c68/attachment.sig>