[Spice-devel] [PATCH spice-common 1/9] messages: Remove fields not used by the protocol

[Christophe Fergeau]

On Sun, Mar 03, 2019 at 07:10:22PM +0000, Frediano Ziglio wrote:
> These fields are not used by the protocol.

Maybe make it explicit that 'not used by the protocol' means they are
not in spice.proto, nor will be used in the generated (de)marshallers.
Apart from this,
Acked-by: Christophe Fergeau <cfergeau at redhat.com>


> Avoid spice-gtk and spice-server to use them by mistake.
> This can cause memory errors (data_size is not used or
> is not set correctly) and useless code (spice-gtk uses
> the pub_key* fields but these fields are not sent to
> the server as the protocol does not have them).
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  common/messages.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/common/messages.h b/common/messages.h
> index 43d3602..f740a8c 100644
> --- a/common/messages.h
> +++ b/common/messages.h
> @@ -43,7 +43,6 @@
>  SPICE_BEGIN_DECLS
>  
>  typedef struct SpiceMsgData {
> -    uint32_t data_size;
>      uint8_t data[0];
>  } SpiceMsgData;
>  
> @@ -75,9 +74,6 @@ typedef struct SpiceMigrationDstInfo {
>      uint16_t sport;
>      uint32_t host_size;
>      uint8_t *host_data;
> -    uint16_t pub_key_type;
> -    uint32_t pub_key_size;
> -    uint8_t *pub_key_data;
>      uint32_t cert_subject_size;
>      uint8_t *cert_subject_data;
>  } SpiceMigrationDstInfo;
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190307/79b74689/attachment.sig>