[Spice-devel] [PATCH spice-common 7/9] codegen: Remove support for --ptrsize

[Frediano Ziglio]

> 
> On Thu, Mar 07, 2019 at 04:01:02PM -0500, Frediano Ziglio wrote:
> > > 
> > > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > > 
> > 
> > Thanks, looking at reply to 9/9 however I think one thing is not clear from
> > what I wrote in the commit message.
> > The reason is not only that was used in protocol 1 only and now is not used
> > but also that it was wrong from the beginning and useless. I would keep it
> > if I found it useful.
> > 
> > > On Sun, Mar 03, 2019 at 07:10:28PM +0000, Frediano Ziglio wrote:
> > > > This option was used in protocol 1 to generate 64 bit pointers.
> > > > A pointer in the protocol is an offset in the current message.
> > > > This allows the possibility to have messages with pointers with
> > > > more than 4GB. This feature was removed and not used in protocol 2.
> > > > The reason is that messages more than 4GB would cause:
> > 
> > Maybe this could be changed in
> > 
> > "The reason this feature was correctly removed in protocol 2 is that
> > having 64 bit pointers in the protocol would require messages larger
> > than 4GB which would cause:"
> 
> Sure, even though the first version was fine too. I would not make as
> big of a difference between "no longer used, and 'harmful'" (this patch)
> and "no longer used and harmless", and would not mind removing both,
> hence my comment on patch #9.
> 
> Christophe
> 

It all started with a patch trying to have the agent protocol turned into
a protocol file. It generate the code using an additional agent.proto file
but I currently don't have patches using. I suspect I'll have to avoid
name clashing as the client will use both "protocols".
So the --prefix/--suffix would be useful although I don't see which
suffix should be appropriate.

Frediano