[Spice-devel] [PATCH spice-common 6/9] Generate automatically most C message declarations

[Frediano Ziglio]

> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> only one caveat is that some of the structs are getting renamed to
> equivalent ones (SpiceMsgDisplayDrawBlend/SpiceMsgDisplayDrawCopy,
> SpiceMsgcMainAgentStart/SpiceMsgcMainAgentTokens and a few more), which
> is fine because they are typedef'ed to the other type anyway
> I guess it's worth mentioned in the commit log.
> 

Original code did something similar, like

  typedef struct SpiceMsgMainAgentTokens {
      uint32_t num_tokens;
  } SpiceMsgMainAgentTokens, SpiceMsgcMainAgentTokens, SpiceMsgcMainAgentStart;

just now is more evident because all the typedefs are in the same place.

> Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Christophe
> 

... omissis ...

Frediano