[Spice-devel] [PATCH spice-server 0/1] prevent crash on video stream reattach

[Frediano Ziglio]

> 
> I experienced some crashes with qemu 3.1.0 compiled with libspice-server
> 0.14.0 on Gentoo.
> 
> The problem reproduced reliably with a guest running Ubuntu 18.04.2 LTS.
> If I connect a viewer at system startup, I would get a crash just after
> the fade-in of the login prompt in GDM.
> 
> Interestingly, I usually was unable to reproduce the issue if I waited
> to connect until after the greeter was fully displayed.
> 
> The patch I used to correct the issue for me applies to the master
> branch cleanly, so I suspect the problem may still exist.
> 
> The only other references to this issue I could find were two abrt
> reports in CentOS:
> https://bugs.centos.org/view.php?id=15171
> https://bugs.centos.org/view.php?id=15441
> 
> I'm not sure if the agent->video_encoder is supposed to be guaranteed to
> exist when this function is called. Please let me know if this is the
> case and I can try to build my qemu with the newest git version of
> libspice-server and reproduce the issue.
> 

I think all this good explanation should be in the commit message
inside in the series introduction, it makes sense to have it in
history.

> Douglas Paul (1):
>   video-stream: prevent crash on stream reattach
> 
>  server/video-stream.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Frediano