[Spice-devel] [PATCH] qxl-wddm-dod: prevent failure of power on transition

[Marek Kedzierski]

----- Original Message -----
> From: "Yuri Benditovich" <yuri.benditovich at daynix.com>
> To: spice-devel at lists.freedesktop.org
> Cc: yan at daynix.com
> Sent: Thursday, February 28, 2019 9:42:17 AM
> Subject: [Spice-devel] [PATCH] qxl-wddm-dod: prevent failure of power on transition
> 
> On return from S3 the driver may receive failure when
> calls DxgkCbAcquirePostDisplayOwnership. In general the
> driver is not expected to use this method when returns
> from S3 but it is not simple to distinguish between S3
> and S4 power transition (possible, due to hybrid sleep).
> Current commit avoids returning error on power transition
> and obtains best known default video mode info instead.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>

Acked-by: Marek Kedzierski <mkedzier at redhat.com>

> ---
>  qxldod/QxlDod.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index 525cdc3..95c0e97 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -5211,9 +5211,10 @@ NTSTATUS
> HwDeviceInterface::AcquireDisplayInfo(DXGK_DISPLAY_INFORMATION& DispInf
>  
>      if (!NT_SUCCESS(Status))
>      {
> -        DbgPrint(TRACE_LEVEL_ERROR, ("QxlDod::AcquireDisplayInfo failed with
> status 0x%X Width = %d\n",
> +        DbgPrint(TRACE_LEVEL_WARNING, ("QxlDod::AcquireDisplayInfo failed
> with status 0x%X Width = %d\n",
>              Status, DispInfo.Width));
> -        return STATUS_UNSUCCESSFUL;
> +        DispInfo.Width = 0;
> +        Status = STATUS_SUCCESS;
>      }
>  
>      if (DispInfo.Width == 0)
> --
> 2.16.1.windows.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel