[Spice-devel] [spice v2] display-channel: monitors_config: add 200ms delay

[Christophe Fergeau]

On Mon, Mar 11, 2019 at 12:12:45PM +0000, Victor Toso wrote:
> Hi,
> 
> On Mon, Mar 11, 2019 at 12:33:20PM +0100, Christophe Fergeau wrote:
> > Hey,
> > 
> > One comment, even if the commit log mentions a bug #, it does not seem
> > to be describing what the bug is/how it's fixed (maybe this can be
> > inferred from the traces, but I did not read them closely as the log
> > does not hint that a bug can be seen by looking at them).
> 
> Oh, well. There is several ways we can write a commit log, like
> there is several ways on how we tell a story. Most of the times,
> I try to explain what the change is about. I do refer to BZ that
> they fix because it is helpful for maintainers and backporting
> patches but I don't see why I need to duplicate BZ comments in
> the commit log too.
> 
> This patch avoids sending multiple monitors_config message to the
> client during short period of time and I tried to explain that.
> I'm more than happy to understand how I can improve the commit
> log but I did not understand how from your comment.

If this commit is fixing a specific bug, then the commit log should have
some description of it/what the fix is. With git, it's entirely possible
that one will be looking at that commit while offline/with bad internet
connection. The bug report may have moved to a different system with a
different bug # in the mean time, the bug report may be long and
confusing, ...
So having a summary in the commit log fixing the bug is imo helpful.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190311/112a819d/attachment.sig>