[Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

[Frediano Ziglio]

> 
> Series looks good to me,
> 
> Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
> 

Why not ack? Not good enough? Not tested? Missing something?

> On Mon, Mar 11, 2019 at 01:59:09PM +0000, Frediano Ziglio wrote:
> > Allows to declare C declarations (that were in common/messages.h)
> > automatically.
> > I added an attribute to:
> > - be compatible;
> > - allows to declare structure in different way than automatic
> >   ones;
> > - allows to use different headers (as draw.h).
> > 
> > Changes since v2:
> > - use a --generate-header option instead of --generated-header not passing
> >   file name but infere from output file name;
> > - remove some TODOs not much related;
> > - commit messages improvements.
> > 
> > Frediano Ziglio (5):
> >   codegen: Factor out a function to write output file
> >   codegen: Generate headers while generating code
> >   codegen: Allows to generate C declarations automatically
> >   Allow to generate C declarations for spice.proto
> >   Generate automatically most C message declarations
> > 
> >  common/Makefile.am          |  22 +-
> >  common/client_marshallers.h |   2 +-
> >  common/meson.build          |  27 +-
> >  common/messages.h           | 493 +-----------------------------------
> >  python_modules/ptypes.py    |  64 +++++
> >  spice.proto                 | 192 +++++++-------
> >  spice_codegen.py            | 108 ++++++--
> >  7 files changed, 284 insertions(+), 624 deletions(-)
> > 

Frediano