[Spice-devel] [spice-gtk 06/13] win-usb-dev: remove unused procedure

Christophe Fergeau cfergeau at redhat.com
Mon Mar 11 17:18:18 UTC 2019


On Sun, Mar 10, 2019 at 04:46:05PM +0200, Yuri Benditovich wrote:
> Remove unused g_udev_device_get_sysfs_attr.
> 

Indeed, last user was apparently removed in 45cfbe8f86c in July 2013.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

> Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>
> ---
>  src/win-usb-dev.c | 18 ------------------
>  src/win-usb-dev.h |  1 -
>  2 files changed, 19 deletions(-)
> 
> diff --git a/src/win-usb-dev.c b/src/win-usb-dev.c
> index d96e52a..85ffd26 100644
> --- a/src/win-usb-dev.c
> +++ b/src/win-usb-dev.c
> @@ -521,24 +521,6 @@ const gchar *g_udev_device_get_property(GUdevDevice *udev, const gchar *property
>      return NULL;
>  }
>  
> -const gchar *g_udev_device_get_sysfs_attr(GUdevDevice *udev, const gchar *attr)
> -{
> -    GUdevDeviceInfo* udevinfo;
> -
> -    g_return_val_if_fail(G_UDEV_DEVICE(udev), NULL);
> -    g_return_val_if_fail(attr != NULL, NULL);
> -
> -    udevinfo = udev->priv->udevinfo;
> -    g_return_val_if_fail(udevinfo != NULL, NULL);
> -
> -
> -    if (g_strcmp0(attr, "bDeviceClass") == 0) {
> -        return udevinfo->sclass;
> -    }
> -    g_warn_if_reached();
> -    return NULL;
> -}
> -
>  #ifdef DEBUG_GUDEV_DEVICE_LISTS
>  static void g_udev_device_print_list(GList *l, const gchar *msg)
>  {
> diff --git a/src/win-usb-dev.h b/src/win-usb-dev.h
> index f3c7466..b7b7eda 100644
> --- a/src/win-usb-dev.h
> +++ b/src/win-usb-dev.h
> @@ -85,7 +85,6 @@ GList *g_udev_client_query_by_subsystem(GUdevClient *client, const gchar *subsys
>  
>  GType g_udev_device_get_type(void) G_GNUC_CONST;
>  const gchar *g_udev_device_get_property(GUdevDevice *udev, const gchar *property);
> -const gchar *g_udev_device_get_sysfs_attr(GUdevDevice *udev, const gchar *attr);
>  
>  GQuark g_udev_client_error_quark(void);
>  #define G_UDEV_CLIENT_ERROR g_udev_client_error_quark()
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190311/f5f819a2/attachment.sig>


More information about the Spice-devel mailing list