[Spice-devel] [spice-gtk 04/13] usb-redir: do not add device if one with the same bus:addr exists

[Yuri Benditovich]

On Mon, Mar 11, 2019 at 7:17 PM Christophe Fergeau <cfergeau at redhat.com> wrote:
>
> On Sun, Mar 10, 2019 at 04:46:03PM +0200, Yuri Benditovich wrote:
> > In initial device enumeration hotplug notification can be
> > called twice with the same libusb device. For details, see
> > http://libusb.sourceforge.net/api-1.0/group__libusb__hotplug.html#ga00e0c69ddf1fb1b6774dc918192e8dc7
> > Filter out devices that already present in the list.
> > Remove indentical call in spice_usb_device_manager_add_udev,
> > which add devices under Windows.
> >
> > Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>
> > ---
> >  src/usb-device-manager.c | 22 +++++++++++-----------
> >  1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> > index debba4d..5cf7ebb 100644
> > --- a/src/usb-device-manager.c
> > +++ b/src/usb-device-manager.c
> > @@ -962,6 +962,17 @@ static void spice_usb_device_manager_add_dev(SpiceUsbDeviceManager  *self,
> >      if (desc.bDeviceClass == LIBUSB_CLASS_HUB)
> >          return;
> >
> > +    if (spice_usb_device_manager_find_device(self,
> > +                                    libusb_get_bus_number(libdev),
> > +                                    libusb_get_device_address(libdev))) {
>
> Forgot to mention that indentation is slightly off.

Please refer exact rule in coding conventions which explains how many
spaces should be inserted to make you think the indentation is ideal.

>
> Christophe
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCAAdFiEElKn3VmH3emFoZJsjqdjCFCmsbIIFAlyGmBEACgkQqdjCFCms
> bIJ4eA//bL+Vfa0yM6oSOVWdeJ+YCflqfvYMCcuznjVZZNVamN3I0/vN4YXTBzIB
> 0natkh86+sMERadKFsdPs6Zy69xgGoTva+jovfiYEC+nCUyvBVMomgTQ9P1bN3kM
> NebhrRD4PiTD4hQUB2mq5Z/Gz8UNcfaBc1VldkQJyTUE08mZusArG4mc//XErfOZ
> aoVTeu14QLBNvUsUEw22/BKSUAPw+T1w0l2Tl50D3XwS+BQCF+Gew04RL6DFloh4
> jsHcGzkQrmAoHnz3gzAzHS4jRfPqTxcHtqz714p9y0+TYF551kh7Qh4X+69e+CGT
> IKZo673rR88yQgJFUvdhsGYzD9R9+fvS1V7+HVDlKt7DuuGRtDNMVrOkzurCJD+u
> nu6H4TDycMzat7uihH56mL7G64htOkTe1mmBMlD2pRZQ0d7ZOn3++dz+Golspp9y
> fdvTQ3y5Ug60vHPzsTsDBDluVL1YX7GHYUNgTyvwtakpsDZ1WzDZOSeaEbcTZJaU
> hsLMIZkh/j4osgIgWlMxdjFddiaW19HX3tKm+Prt43b86XKyOW1yYCJU+zX6YZO7
> zFl8jDo2oCa+ZAELrmhGYZy2CQVkRObaUXoyJZS5+JDu9MmDtxSWfmkIyAXkBHBx
> rbAwuivLxI/O3zsgHqyKGgLUsxN1+VoxJkFUIzZcqHSln7l9n10=
> =UbTl
> -----END PGP SIGNATURE-----