[Spice-devel] [PATCH] usbredirserver: Make compile under MacOS

Christophe de Dinechin cdupontd at redhat.com
Thu Mar 14 08:56:07 UTC 2019



> On 29 Jan 2019, at 10:23, Christophe Fergeau <cfergeau at redhat.com> wrote:
> 
> On Mon, Jan 28, 2019 at 02:28:36PM -0500, Frediano Ziglio wrote:
>>> On Wed, Jan 23, 2019 at 10:09:25AM +0000, Frediano Ziglio wrote:
>>>> This fixes Gitlab issue #9
>>>> (cfr https://gitlab.freedesktop.org/spice/usbredir/issues/9).
>>>> 
>>>> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
>>>> ---
>>>> usbredirserver/usbredirserver.c | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>> 
>>>> diff --git a/usbredirserver/usbredirserver.c
>>>> b/usbredirserver/usbredirserver.c
>>>> index 6aa2740..429985a 100644
>>>> --- a/usbredirserver/usbredirserver.c
>>>> +++ b/usbredirserver/usbredirserver.c
>>>> @@ -43,6 +43,13 @@
>>>> 
>>>> #define SERVER_VERSION "usbredirserver " PACKAGE_VERSION
>>>> 
>>>> +#if !defined(SOL_TCP) && defined(IPPROTO_TCP)
>>>> +#define SOL_TCP IPPROTO_TCP
>>>> +#endif
>>>> +#if !defined(TCP_KEEPIDLE) && defined(TCP_KEEPALIVE)
>>>> +#define TCP_KEEPIDLE TCP_KEEPALIVE
>>>> +#endif
>>> 
>>> Might be better to restrict this to OSX in case a system decides to
>>> use TCP_KEEPALIVE, but with a different meaning?
>>> 
>> 
>> So
>> 
>> #if !defined(TCP_KEEPIDLE) && defined(TCP_KEEPALIVE) && defined(__APPLE__)
> 
> Yep, or even just #if defined(__APPLE__)

I prefer Frediano’s version, Apple may change it later.

> 
> Christophe
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



More information about the Spice-devel mailing list