[Spice-devel] [PATCH spice-server 1/2] test-stream-device: Remove interface before next loop

[Christophe Fergeau]

On Tue, Mar 19, 2019 at 01:01:54PM +0000, Frediano Ziglio wrote:
> We should not reuse the same interface twice as doing so will
> cause dandling pointers.

'dangling'

Acked-by: Christophe Fergeau <cfergeau at redhat.com>


> Unregister it at every iteration.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/tests/test-stream-device.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> This avoids next patch to cause failure during tests.
> 
> diff --git a/server/tests/test-stream-device.c b/server/tests/test-stream-device.c
> index e63952ac..ce37822f 100644
> --- a/server/tests/test-stream-device.c
> +++ b/server/tests/test-stream-device.c
> @@ -342,6 +342,7 @@ static void test_stream_device(TestFixture *fixture, gconstpointer user_data)
>          g_assert(message_sizes_curr - message_sizes == 5 || !device_enabled);
>  
>          check_vmc_error_message();
> +        spice_server_remove_interface(&vmc_instance.base);
>      }
>  }
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190319/3b7dc47a/attachment.sig>