[Spice-devel] [spice] Consistently check if drm_dma_buf_fd is greater or lower than zero

Francois Gouget fgouget at codeweavers.com
Thu Mar 21 10:20:46 UTC 2019


Based on a patch by Frediano Ziglio.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 server/red-qxl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/red-qxl.c b/server/red-qxl.c
index 0dd26b22c..789817f69 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -791,7 +791,7 @@ void spice_qxl_gl_scanout(QXLInstance *qxl,
 
     pthread_mutex_lock(&qxl_state->scanout_mutex);
 
-    if (qxl_state->scanout.drm_dma_buf_fd != -1) {
+    if (qxl_state->scanout.drm_dma_buf_fd >= 0) {
         close(qxl_state->scanout.drm_dma_buf_fd);
     }
 
@@ -832,7 +832,7 @@ void spice_qxl_gl_draw_async(QXLInstance *qxl,
 
     spice_return_if_fail(qxl != NULL);
     qxl_state = qxl->st;
-    if (qxl_state->scanout.drm_dma_buf_fd == -1) {
+    if (qxl_state->scanout.drm_dma_buf_fd < 0) {
         spice_warning("called spice_qxl_gl_draw_async without a buffer");
         red_qxl_async_complete(qxl, cookie);
         return;
-- 
2.20.1



More information about the Spice-devel mailing list