[Spice-devel] [PATCH spice-protocol 1/3] Add a .gitpublish

Daniel P. Berrangé berrange at redhat.com
Fri Mar 22 14:06:28 UTC 2019


On Fri, Mar 22, 2019 at 02:56:46PM +0100, marcandre.lureau at redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau at redhat.com>
> 
> Set a default profile for git-publish.
> (https://github.com/stefanha/git-publish)
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> ---
>  .gitpublish | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 .gitpublish
> 
> diff --git a/.gitpublish b/.gitpublish
> new file mode 100644
> index 0000000..80d46b2
> --- /dev/null
> +++ b/.gitpublish
> @@ -0,0 +1,4 @@
> +[gitpublishprofile "default"]
> +to = spice-devel at lists.freedesktop.org
> +prefix = PATCH spice-protocol
> +signoff = true

Setting signoff=true is defeating the purpose of signing off commits IMHO.

The act of adding the S-o-B is usually expected to be a concious decision
by the developer, to assert that their contribution is in compliance with
the DCO (or equivalent contribution rules the project defines [1]).

If tools add the S-o-B automatically with no developer decision involved,
then it looses its meaning and adds no value over the Author: metadata
git already provides by default.

Regards,
Daniel

[1] I'm actually not seeing anything in spice-protocol git that says
    what adding the S-o-B actually means for contributors. Usually
    there should be a copy of the DCO or something in CONTIRBUTING or
    README file to point to it online.
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


More information about the Spice-devel mailing list