[Spice-devel] [PATCH spice-gtk 0/2] clipboard: skip release between grabs

[Jakub Janku]

Hi,

On Fri, Mar 22, 2019 at 10:15 AM Victor Toso <victortoso at redhat.com> wrote:
>
> Hi James,
>
> If you have the time, could you give this a try?

CC-ing James
>
> Cheers,
>
> On Thu, Mar 21, 2019 at 01:21:32PM +0100, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > Hi,
> >
> > There has been several reports of clipboard issues that seem related
> > to clipboard managers interactions. Although it's not crystal clear
> > what are the problems,

Hmmm. What's left to be cleared?

>> we realized the spice protocol does't handle
> > well conflicting grabs coming simultaneously from client and remote.
> > Each other believe the other side is the owner. This situation
> > is rare, but with a clipboard manager that reacts to release events,
> > it may be more easily reproducible.
> >
> > Both agent & client send release between grabs today. This series
> > propose to stop releasing between grabs on client side, and adds a
> > 0.5s delay for the release event coming from the agent side, to filter
> > out release between grabs.

Delaying the release for 0.5 seconds seems wrong to me. Given it's
just a temporary workaround, I'm fine with it.
But it should be tested by someone who's experienced the issues in the
real world to see if the delay is sufficient and doesn't cause any
other problems.
> >
> > Further protocol improvements should remove the need for a delay, and
> > solve the conflicting situation in all cases. This will come in a
> > future series.
> >
> > Marc-André Lureau (2):
> >   clipboard: do not release between client grabs
> >   clipboard: do not release between remote grabs
> >
> >  src/spice-gtk-session.c | 101 +++++++++++++++++++++++++++++++---------
> >  1 file changed, 80 insertions(+), 21 deletions(-)
> >
> > --
> > 2.21.0.4.g36eb1cb9cf
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel

Cheers,
Jakub