[Spice-devel] [spice-gtk 2/2] win-usb-dev: Use 'stable' libusb_device pointers in GUdevClient::udev_list

[Christophe Fergeau]

On Mon, Mar 25, 2019 at 08:03:05PM +0200, Yuri Benditovich wrote:
> Yes, it looks like this finally does the same thing.

> From my personal point of view, this is less obvious than previous
> code, so I would add 2 comments:
> that we unreference the device from the new list
> that we add reference to the device from the old list, it will be
> dereferenced on next line when the old list freed

If the part you find less clear is:
+            libusb_unref_device(dev->data);
+            dev->data = libusb_ref_device(found->data);

I don't really mind changing it back to do the swapping with an
intermediate variable, even if I personally find the unref/ref to be
more readable than the other version ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190326/2896da36/attachment.sig>