[Spice-devel] [spice-common 6/8] test-marshallers: Fix header guard

Frediano Ziglio fziglio at redhat.com
Thu Mar 28 17:54:01 UTC 2019


> 
> test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
> prevent multiple #include for the same header.
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  tests/test-marshallers.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/test-marshallers.h b/tests/test-marshallers.h
> index 4eab90f..5b113b7 100644
> --- a/tests/test-marshallers.h
> +++ b/tests/test-marshallers.h
> @@ -1,6 +1,7 @@
>  #include <stdint.h>
>  

OT: why this is outside the guard?

>  #ifndef _H_TEST_MARSHALLERS
> +#define _H_TEST_MARSHALLERS
>  

OT 2: Why not H_SPICE_COMMON_ prefix?

>  typedef struct {
>      uint32_t data_size;

beside, 

acked

Frediano


More information about the Spice-devel mailing list