[Spice-devel] [PATCH spice-protocol] protocol: Generate enums.h again to remove old protocol definitions

[Christophe Fergeau]

On Wed, Mar 27, 2019 at 04:24:02AM -0400, Frediano Ziglio wrote:
> ping

Acked-by: Christophe Fergeau <cfergeau at redhat.com>
though imo this should be reflected in version numbering ;)

> 
> > > 
> > > This is breaking spice-protocol API even if this should not impact
> > > current code. Do we want to advertise this somehow? Switch to
> > > spice-protocol 0.14.x?
> > > 
> > 
> > Fine for me both 0.14.0 or 0.12.16 (the future, current HEAD version)
> > 
> > > On Fri, Feb 22, 2019 at 12:16:52PM +0000, Frediano Ziglio wrote:
> > > > spice.proto was updated to remove really old definitions,
> > > > update enums.h accordingly.
> > > > 
> > > > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > > > ---
> > > >  spice/enums.h | 57 ---------------------------------------------------
> > > >  1 file changed, 57 deletions(-)
> > > > 
> > > > diff --git a/spice/enums.h b/spice/enums.h
> > > > index 34e84c3..172cc4d 100644
> > > > --- a/spice/enums.h
> > > > +++ b/spice/enums.h
> > > > @@ -119,21 +119,6 @@ typedef enum SpiceMouseMode {
> > > >      SPICE_MOUSE_MODE_MASK = 0x3
> > > >  } SpiceMouseMode;
> > > >  
> > > > -typedef enum SpicePubkeyType {
> > > > -    SPICE_PUBKEY_TYPE_INVALID,
> > > > -    SPICE_PUBKEY_TYPE_RSA,
> > > > -    SPICE_PUBKEY_TYPE_RSA2,
> > > > -    SPICE_PUBKEY_TYPE_DSA,
> > > > -    SPICE_PUBKEY_TYPE_DSA1,
> > > > -    SPICE_PUBKEY_TYPE_DSA2,
> > > > -    SPICE_PUBKEY_TYPE_DSA3,
> > > > -    SPICE_PUBKEY_TYPE_DSA4,
> > > > -    SPICE_PUBKEY_TYPE_DH,
> > > > -    SPICE_PUBKEY_TYPE_EC,
> > > > -
> > > > -    SPICE_PUBKEY_TYPE_ENUM_END
> > > > -} SpicePubkeyType;
> > > > -
> > > >  typedef enum SpiceDataCompressionType {
> > > >      SPICE_DATA_COMPRESSION_TYPE_NONE,
> > > >      SPICE_DATA_COMPRESSION_TYPE_LZ4,
> > > > @@ -397,21 +382,6 @@ typedef enum SpiceAudioFmt {
> > > >      SPICE_AUDIO_FMT_ENUM_END
> > > >  } SpiceAudioFmt;
> > > >  
> > > > -typedef enum SpiceTunnelServiceType {
> > > > -    SPICE_TUNNEL_SERVICE_TYPE_INVALID,
> > > > -    SPICE_TUNNEL_SERVICE_TYPE_GENERIC,
> > > > -    SPICE_TUNNEL_SERVICE_TYPE_IPP,
> > > > -
> > > > -    SPICE_TUNNEL_SERVICE_TYPE_ENUM_END
> > > > -} SpiceTunnelServiceType;
> > > > -
> > > > -typedef enum SpiceTunnelIpType {
> > > > -    SPICE_TUNNEL_IP_TYPE_INVALID,
> > > > -    SPICE_TUNNEL_IP_TYPE_IPv4,
> > > > -
> > > > -    SPICE_TUNNEL_IP_TYPE_ENUM_END
> > > > -} SpiceTunnelIpType;
> > > > -
> > > >  typedef enum SpiceVscMessageType {
> > > >      SPICE_VSC_MESSAGE_TYPE_Init = 1,
> > > >      SPICE_VSC_MESSAGE_TYPE_Error,
> > > > @@ -613,33 +583,6 @@ enum {
> > > >      SPICE_MSGC_END_RECORD
> > > >  };
> > > >  
> > > > -enum {
> > > > -    SPICE_MSG_TUNNEL_INIT = 101,
> > > > -    SPICE_MSG_TUNNEL_SERVICE_IP_MAP,
> > > > -    SPICE_MSG_TUNNEL_SOCKET_OPEN,
> > > > -    SPICE_MSG_TUNNEL_SOCKET_FIN,
> > > > -    SPICE_MSG_TUNNEL_SOCKET_CLOSE,
> > > > -    SPICE_MSG_TUNNEL_SOCKET_DATA,
> > > > -    SPICE_MSG_TUNNEL_SOCKET_CLOSED_ACK,
> > > > -    SPICE_MSG_TUNNEL_SOCKET_TOKEN,
> > > > -
> > > > -    SPICE_MSG_END_TUNNEL
> > > > -};
> > > > -
> > > > -enum {
> > > > -    SPICE_MSGC_TUNNEL_SERVICE_ADD = 101,
> > > > -    SPICE_MSGC_TUNNEL_SERVICE_REMOVE,
> > > > -    SPICE_MSGC_TUNNEL_SOCKET_OPEN_ACK,
> > > > -    SPICE_MSGC_TUNNEL_SOCKET_OPEN_NACK,
> > > > -    SPICE_MSGC_TUNNEL_SOCKET_FIN,
> > > > -    SPICE_MSGC_TUNNEL_SOCKET_CLOSED,
> > > > -    SPICE_MSGC_TUNNEL_SOCKET_CLOSED_ACK,
> > > > -    SPICE_MSGC_TUNNEL_SOCKET_DATA,
> > > > -    SPICE_MSGC_TUNNEL_SOCKET_TOKEN,
> > > > -
> > > > -    SPICE_MSGC_END_TUNNEL
> > > > -};
> > > > -
> > > >  enum {
> > > >      SPICE_MSG_SMARTCARD_DATA = 101,
> > > >  
> > 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190329/78b24f28/attachment.sig>