[Spice-devel] [spice-streaming-agent PATCH] mjpeg: get_time: fix off-by-0

Frediano Ziglio fziglio at redhat.com
Sun Mar 31 13:05:16 UTC 2019


> Subject: [Spice-devel] [spice-streaming-agent PATCH] mjpeg: get_time: fix off-by-0
> 
> Only 9 0's are required
> 
> Signed-off-by: Uri Lublin <uril at redhat.com>

Code is fine, comment I'm not sure about.
Usually off-by- refers to a difference.
"'s" is meaning possess or relation while here you want to
express "zeroes", so could be "0s", not 0's.

I'll leave the final word to some native English speakers.

> ---
>  src/mjpeg-fallback.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp
> index 09f3769..1b263f2 100644
> --- a/src/mjpeg-fallback.cpp
> +++ b/src/mjpeg-fallback.cpp
> @@ -26,7 +26,7 @@ static inline uint64_t get_time()
>  
>      clock_gettime(CLOCK_MONOTONIC, &now);
>  
> -    return (uint64_t)now.tv_sec * 10000000000u + (uint64_t)now.tv_nsec;
> +    return (uint64_t)now.tv_sec * 1000000000u + (uint64_t)now.tv_nsec;
>  }
>  
>  namespace {

Frediano


More information about the Spice-devel mailing list