[Spice-devel] [PATCH spice-gtk] build: Add some missing check for headers

[Victor Toso]

Hi,

On Wed, May 01, 2019 at 08:46:35AM +0100, Frediano Ziglio wrote:
> Headers macros (HAVE_*_H) are guarding some include in the code.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  configure.ac |  2 +-
>  meson.build  | 10 ++++++++--
>  2 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 0666e2a8..61591691 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -71,7 +71,7 @@ esac
>  AC_MSG_RESULT([$os_mac])
>  AM_CONDITIONAL([OS_MAC],[test "$os_mac" = "yes"])
>  
> -AC_CHECK_HEADERS([sys/socket.h netinet/in.h arpa/inet.h])
> +AC_CHECK_HEADERS([sys/socket.h sys/types.h netinet/in.h arpa/inet.h])
>  AC_CHECK_HEADERS([termios.h])
>  AC_CHECK_HEADERS([epoxy/egl.h],
>                   [have_egl=yes],
> diff --git a/meson.build b/meson.build
> index e0fba930..8c6288f3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -48,8 +48,14 @@ keymapcsv = files('subprojects/keycodemapdb/data/keymaps.csv')
>  #
>  # check for system headers
>  #
> -headers = ['termios.h',
> -           'X11/XKBlib.h']
> +headers = [
> +  'termios.h',
> +  'X11/XKBlib.h',
> +  'sys/socket.h',
> +  'sys/types.h',
> +  'netinet/in.h',
> +  'arpa/inet.h',
> +]

Acked-by: Victor Toso <victortoso at redhat.com>

>  
>  foreach header : headers
>    if compiler.has_header(header)
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190502/91c0ee63/attachment.sig>