[Spice-devel] [PATCH v2 x11spice 2/4] Apply Spice style to the spice-video-dummy

[Jeremy White]

Hi Frediano,

Thanks for the review.  I've condensed the thread to just a few 
interesting points; for the most part, I was able to get indent to make 
the changes you requested, and will resubmit with that.


>> +    if (!infoPtr)
>> +        return FALSE;
>>   
> 
> What we usually want is always brackets for if so
> 
>     if (!infoPtr) {
>         return FALSE;
>     }
> 
> (this should be doable using indent, not sure how).

I did not find a way.  I've chosen not to try to fix these, there are a 
fair number from the upstream code, and I worry that manual edits will 
create bugs.  If this particular style convention is absolutely vital, I 
can do that work as well, he said grudgingly <grin>.

> 
>>       dPtr->CursorInfo = infoPtr;
>>   
>> @@ -94,9 +87,6 @@ DUMMYCursorInit(ScreenPtr pScreen)
>>       infoPtr->ShowCursor = dummyShowCursor;
>>       infoPtr->UseHWCursor = dummyUseHWCursor;
>>   /*     infoPtr->RealizeCursor = dummyRealizeCursor; */
>> -
>> -    return(xf86InitCursor(pScreen, infoPtr));
>> -}
>> -
>> -
>>   
>> +    return (xf86InitCursor(pScreen, infoPtr));
> 
> I would remove the parenthesis, like
> 
>     return xf86InitCursor(pScreen, infoPtr);
> 
> (not strong)

(not changed)  :-/.

Cheers,

Jeremy