[Spice-devel] [spice-gtk 0/2] channel-usbredir ifdef USE_USBREDIR fixes

Frediano Ziglio fziglio at redhat.com
Sat May 4 17:57:31 UTC 2019


> 
> From: Victor Toso <me at victortoso.com>
> 
> Hi,
> 
> A compiler warning fix on first patch. I can trigger that warning when I
> disable usbredir. I'm using gcc 8.3.1 but I think I saw it long time
> ago too.
> 

It occurs also here
https://gitlab.freedesktop.org/spice/spice-gtk/-/jobs/275471

> Second patch is self explanatory, I hope it sounds reasonable.
> 

Agreed

> gitlab-ci:
> https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/35077
> 
> Cheers,
> 
> Victor Toso (2):
>   channel-usbredir: if disabled, define type without private
>   channel-usbredir: reduce amount of #ifdef USE_USBREDIR
> 
>  src/channel-usbredir.c | 32 ++++++++++++++------------------
>  1 file changed, 14 insertions(+), 18 deletions(-)
> 

Frediano


More information about the Spice-devel mailing list