[Spice-devel] [PATCH spice-gtk] build: Do not generate ChangeLog file

[Victor Toso]

Hi,

On Wed, May 15, 2019 at 09:17:12AM +0100, Frediano Ziglio wrote:
> There's already a hand written change log and people can look
> at repository history.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Looks fine,
Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  Makefile.am | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 9fcb2d3b..3c607c9a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -40,18 +40,8 @@ MAINTAINERCLEANFILES =					\
>  	gtk-doc.make					\
>  	$(NULL)
>  
> -# Generate the ChangeLog file
> -# and insert it into the directory we're about to use to create a tarball.
> -.PHONY: gen-ChangeLog gen-THANKS
> -gen-ChangeLog:
> -	if test -d .git || test -d ../.git; then				\
> -	  $(top_srcdir)/build-aux/gitlog-to-changelog > $(distdir)/cl-t;	\
> -	  rm -f $(distdir)/ChangeLog;						\
> -	  mv $(distdir)/cl-t $(distdir)/ChangeLog;				\
> -	fi
> -
>  # see git-version-gen
> -dist-hook: gen-ChangeLog gen-THANKS
> +dist-hook: gen-THANKS
>  	echo $(VERSION) > $(distdir)/.tarball-version
>  
>  BUILT_SOURCES = $(top_srcdir)/.version
> @@ -68,6 +58,9 @@ DISTCHECK_CONFIGURE_FLAGS =			\
>  	--with-gtk=3.0				\
>  	$(NULL)
>  
> +# Generate the THANKS file
> +# and insert it into the directory we're about to use to create a tarball.
> +.PHONY: gen-THANKS
>  gen-THANKS:
>  	$(AM_V_GEN)if test -d .git || test -d ../.git; then						\
>  	  echo "The spice-gtk team would like to thank the following contributors:" > $(distdir)/t-t;	\
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190515/01ef6d8e/attachment.sig>