[Spice-devel] [PATCH spice-server] spice-experimental: Remove obsolete file

Snir Sheriber ssheribe at redhat.com
Sun May 19 14:49:13 UTC 2019


Hi,


ack

(looks safe to remove but i didn't push yet (if someone want to object 
by tomorrow ))


On 5/18/19 10:55 AM, Frediano Ziglio wrote:
> This header was removed in 2014 (3c6b4e415) as deprecated and added again
> in 2015 (2e88eb705) as causing some issue with former Qemu versions.
> After 4 years remove again, now there should not be any usage of it.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>   server/Makefile.am          |  1 -
>   server/meson.build          |  1 -
>   server/spice-experimental.h | 24 ------------------------
>   3 files changed, 26 deletions(-)
>   delete mode 100644 server/spice-experimental.h
>
> CI results https://gitlab.freedesktop.org/fziglio/spice/pipelines/37607
>
> diff --git a/server/Makefile.am b/server/Makefile.am
> index 7f260612..20adf65f 100644
> --- a/server/Makefile.am
> +++ b/server/Makefile.am
> @@ -64,7 +64,6 @@ libspice_serverinclude_HEADERS =		\
>   	spice-audio.h				\
>   	spice-char.h				\
>   	spice-core.h				\
> -	spice-experimental.h			\
>   	spice-input.h				\
>   	spice-migration.h			\
>   	spice-qxl.h				\
> diff --git a/server/meson.build b/server/meson.build
> index 34d8eef1..2ca43e9c 100644
> --- a/server/meson.build
> +++ b/server/meson.build
> @@ -26,7 +26,6 @@ spice_server_headers = [
>     'spice-audio.h',
>     'spice-char.h',
>     'spice-core.h',
> -  'spice-experimental.h',
>     'spice-input.h',
>     'spice-migration.h',
>     'spice-qxl.h',
> diff --git a/server/spice-experimental.h b/server/spice-experimental.h
> deleted file mode 100644
> index 589e29bf..00000000
> --- a/server/spice-experimental.h
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */
> -/*
> -   Copyright (C) 2009-2015 Red Hat, Inc.
> -
> -   This library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   This library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with this library; if not, see <http://www.gnu.org/licenses/>.
> -*/
> -
> -#ifndef SPICE_EXPERIMENTAL_H_
> -#define SPICE_EXPERIMENTAL_H_
> -
> -#warning spice-experimental.h is deprecated
> -
> -#endif /* SPICE_EXPERIMENTAL_H_ */


More information about the Spice-devel mailing list