[Spice-devel] [PATCH spice-gtk] spice-client-gtk-module: Remove unused file

[Snir Sheriber]

On 5/20/19 10:13 AM, Frediano Ziglio wrote:
>> Hi,
>>
>> Maybe worth mentioning it's leftover from pygtk/python bindings
>> not really critical, anyway, fine with me.
>>
> Do you have the commit or some hint on what to write?
> I'm not aware of this feature.


I think it should have been removed in 96ed6b7a and missed.
So i guess same subject would work "pygtk: remove bindings leftover"

Snir.


>
>> Acked-by: Snir Sheriber <ssheribe at redhat.com>
>>
>> On 5/17/19 1:41 PM, Frediano Ziglio wrote:
>>> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
>>> ---
>>>    src/spice-client-gtk-module.c | 45 -----------------------------------
>>>    1 file changed, 45 deletions(-)
>>>    delete mode 100644 src/spice-client-gtk-module.c
>>>
>>> diff --git a/src/spice-client-gtk-module.c b/src/spice-client-gtk-module.c
>>> deleted file mode 100644
>>> index b82f1e34..00000000
>>> --- a/src/spice-client-gtk-module.c
>>> +++ /dev/null
>>> @@ -1,45 +0,0 @@
>>> -/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */
>>> -/*
>>> -   Copyright (C) 2010 Red Hat, Inc.
>>> -
>>> -   This library is free software; you can redistribute it and/or
>>> -   modify it under the terms of the GNU Lesser General Public
>>> -   License as published by the Free Software Foundation; either
>>> -   version 2.1 of the License, or (at your option) any later version.
>>> -
>>> -   This library is distributed in the hope that it will be useful,
>>> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> -   Lesser General Public License for more details.
>>> -
>>> -   You should have received a copy of the GNU Lesser General Public
>>> -   License along with this library; if not, see
>>> <http://www.gnu.org/licenses/>.
>>> -*/
>>> -#include "config.h"
>>> -#include <pygobject.h>
>>> -
>>> -void spice_register_classes (PyObject *d);
>>> -void spice_add_constants(PyObject *module, const gchar *strip_prefix);
>>> -extern PyMethodDef spice_functions[];
>>> -
>>> -DL_EXPORT(void) initSpiceClientGtk(void)
>>> -{
>>> -    PyObject *m, *d;
>>> -
>>> -    init_pygobject();
>>> -
>>> -    m = Py_InitModule("SpiceClientGtk", spice_functions);
>>> -    if (PyErr_Occurred())
>>> -        Py_FatalError("can't init module");
>>> -
>>> -    d = PyModule_GetDict(m);
>>> -    if (PyErr_Occurred())
>>> -        Py_FatalError("can't get dict");
>>> -
>>> -    spice_register_classes(d);
>>> -    spice_add_constants(m, "SPICE_");
>>> -
>>> -    if (PyErr_Occurred()) {
>>> -        Py_FatalError("can't initialise module SpiceClientGtk");
>>> -    }
>>> -}