[Spice-devel] [spice v2] gstreamer-encoder: Show the source fps when the system is too slow

Frediano Ziglio fziglio at redhat.com
Tue May 21 07:47:29 UTC 2019


> 
> The source framerate is as important as the resolution when trying to
> understand if the system should be fast enough to encode the video
> stream in real time.
> 
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>

Acked-by: Frediano Ziglio <fziglio at redhat.com>

> ---
> 
> v2: Tweaked the message.
> 
>  server/gstreamer-encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> index 0101b36fa..bccbe0660 100644
> --- a/server/gstreamer-encoder.c
> +++ b/server/gstreamer-encoder.c
> @@ -542,7 +542,7 @@ static void update_next_frame_mm_time(SpiceGstEncoder
> *encoder)
>      uint64_t period_ns = NSEC_PER_SEC / get_source_fps(encoder);
>      uint64_t min_delay_ns = get_average_encoding_time(encoder);
>      if (min_delay_ns > period_ns) {
> -        spice_warning("your system seems to be too slow to encode this %dx%d
> video in real time", encoder->width, encoder->height);
> +        spice_warning("your system seems to be too slow to encode this
> %dx%d@%d video in real time", encoder->width, encoder->height,
> get_source_fps(encoder));
>      }
>  
>      min_delay_ns = MIN(min_delay_ns, SPICE_GST_MAX_PERIOD);


More information about the Spice-devel mailing list