[Spice-devel] [PATCH spice-server 8/8] red-channel-client: Use SpiceMsgcAckSync structure

Victor Toso victortoso at redhat.com
Tue Oct 8 16:01:11 UTC 2019


Hi,

For the 6-8/8 (pending)
Acked-by: Victor Toso <victortoso at redhat.com>

On Mon, Oct 07, 2019 at 11:39:06AM +0100, Frediano Ziglio wrote:
> red_channel_client_handle_message is called after parsing the
> message so it's not necessary to check it again or parse manually.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/red-channel-client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red-channel-client.c b/server/red-channel-client.c
> index 832b4175..c3ad6818 100644
> --- a/server/red-channel-client.c
> +++ b/server/red-channel-client.c
> @@ -1464,7 +1464,7 @@ bool red_channel_client_handle_message(RedChannelClient *rcc, uint16_t type,
>  {
>      switch (type) {
>      case SPICE_MSGC_ACK_SYNC:
> -        rcc->priv->ack_data.client_generation = *(uint32_t *)(message);
> +        rcc->priv->ack_data.client_generation = ((SpiceMsgcAckSync *) message)->generation;
>          break;
>      case SPICE_MSGC_ACK:
>          if (rcc->priv->ack_data.client_generation == rcc->priv->ack_data.generation) {
> -- 
> 2.21.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20191008/d79ef0a0/attachment.sig>


More information about the Spice-devel mailing list