[Spice-devel] [PATCH spice-server v2 1/7] smartcard-channel-client: Remove properties code

[Victor Toso]

Hi,

On Tue, Oct 08, 2019 at 06:39:18PM +0100, Frediano Ziglio wrote:
> Not used
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Yes, these are basically what default implementation does and if
no plans to extend it are in place, removing should be fine

Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  server/smartcard-channel-client.c | 26 --------------------------
>  1 file changed, 26 deletions(-)
> 
> diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c
> index f71b65238..d47b442e4 100644
> --- a/server/smartcard-channel-client.c
> +++ b/server/smartcard-channel-client.c
> @@ -47,30 +47,6 @@ smartcard_channel_client_release_msg_rcv_buf(RedChannelClient *rcc, uint16_t typ
>                                               uint32_t size, uint8_t *msg);
>  static void smartcard_channel_client_on_disconnect(RedChannelClient *rcc);
>  
> -static void smart_card_channel_client_get_property(GObject *object,
> -                                                   guint property_id,
> -                                                   GValue *value,
> -                                                   GParamSpec *pspec)
> -{
> -    switch (property_id)
> -    {
> -        default:
> -            G_OBJECT_WARN_INVALID_PROPERTY_ID(object, property_id, pspec);
> -    }
> -}
> -
> -static void smart_card_channel_client_set_property(GObject *object,
> -                                                   guint property_id,
> -                                                   const GValue *value,
> -                                                   GParamSpec *pspec)
> -{
> -    switch (property_id)
> -    {
> -        default:
> -            G_OBJECT_WARN_INVALID_PROPERTY_ID(object, property_id, pspec);
> -    }
> -}
> -
>  static void smart_card_channel_client_finalize(GObject *object)
>  {
>      SmartCardChannelClient *self = SMARTCARD_CHANNEL_CLIENT(object);
> @@ -90,8 +66,6 @@ static void smart_card_channel_client_class_init(SmartCardChannelClientClass *kl
>      client_class->release_recv_buf = smartcard_channel_client_release_msg_rcv_buf;
>      client_class->on_disconnect = smartcard_channel_client_on_disconnect;
>  
> -    object_class->get_property = smart_card_channel_client_get_property;
> -    object_class->set_property = smart_card_channel_client_set_property;
>      object_class->finalize = smart_card_channel_client_finalize;
>  }
>  
> -- 
> 2.21.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20191009/b2a3548e/attachment-0001.sig>