[Spice-devel] [spice/docs] docs: include protocol and for-newbies documents

Frediano Ziglio fziglio at redhat.com
Mon Oct 14 11:00:03 UTC 2019


> 
> From: Victor Toso <me at victortoso.com>
> 
> Only by building and sharing the documents we will be able to get them
> up to date.
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  docs/meson.build | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/meson.build b/docs/meson.build
> index 82864bb8..ce0334c0 100644
> --- a/docs/meson.build
> +++ b/docs/meson.build
> @@ -1,11 +1,17 @@
> +asciidoc_files = ['spice_for_newbies',
> +                  'spice_protocol',
> +                  'spice_style',
> +                  'spice_threading_model',
> +                  'vd_interfaces']
> +

Only a minor, why not maintaining the same order of Makefile.am
(I would say either changing Makefile.am or meson.build) ?

>  if get_option('manual')
>    asciidoc = find_program('asciidoc', required : false)
>    if asciidoc.found()
>      asciidoc_args = ['-a', 'data-uri', '-a', 'icons', '-a', 'toc']
> -    foreach doc : ['style', 'threading_model']
> -      custom_target('spice_ at 0@.html'.format(doc),
> -                    input : 'spice_ at 0@.txt'.format(doc),
> -                    output : 'spice_ at 0@.html'.format(doc),
> +    foreach doc : asciidoc_files
> +      custom_target('@0 at .html'.format(doc),
> +                    input : '@0 at .txt'.format(doc),
> +                    output : '@0 at .html'.format(doc),
>                      build_by_default: true,
>                      command : [asciidoc, '-n', asciidoc_args, '-o',
>                      '@OUTPUT@', '@INPUT@'])
>      endforeach

Otherwise,
  Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list