[Spice-devel] [PATCH spice-server] spice_protocol: Update many names

Frediano Ziglio fziglio at redhat.com
Mon Oct 14 11:02:05 UTC 2019


> Hi,
> 
> On Thu, Oct 10, 2019 at 03:56:30PM +0100, Frediano Ziglio wrote:
> > Using an old "renames" file found in spice-protocol repository
> > I update some old names in the documentation protocol.
> > Also updated some other names manually.
> > I processed the file and fixed some code indentation.
> > File looks much more up to date.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> 
> I'd add doc: as prefix of shortlog to be clear that commit
> purpose is on docs. I had a quick look and built and checked the
> html, looks okay. I've also sent a patch to add this and others
> in meson.build
> 

So, better to change shortlog to:

docs: Update many names in spice_protocol.txt

??

> Acked-by: Victor Toso <victortoso at redhat.com>
> 
> > ---
> >  docs/spice_protocol.txt | 808 ++++++++++++++++++++--------------------
> >  1 file changed, 404 insertions(+), 404 deletions(-)
> > 
> > diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt
> > index 58bc01664..d191462d1 100644
> > --- a/docs/spice_protocol.txt
> > +++ b/docs/spice_protocol.txt
> > @@ -51,10 +51,10 @@ is in little endian format.
> >  .. UINT32 – 32 bits unsigned  integer
> >  .. INT32 - 32 bits signed integer
> >  .. UINT64 – 64 bits unsigned  integer
> > -.. ADDRESS - 64 bits unsigned integer, value is the offset of the
> > addressed
> > +.. SPICE_ADDRESS - 64 bits unsigned integer, value is the offset of the
> > addressed
> >  data from the beginning of spice protocol message body (i.e., data
> >  following
> > -RedDataHeader or RedSubMessage).
> > -.. FIXED28_4 – 32 bits fixed point number. 28 high bits are signed
> > integer. Low
> > +SpiceDataHeader or SpicedSubMessage).
> > +.. SPICE_FIXED28_4 – 32 bits fixed point number. 28 high bits are signed
> > integer. Low

... omissis ...

Frediano


More information about the Spice-devel mailing list