[Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

[Victor Toso]

Hi,

On Mon, Oct 14, 2019 at 09:18:51AM -0400, Frediano Ziglio wrote:
> > 
> > Hi,
> > 
> > On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote:
> > > This series is part from a former series.
> > > There's an initial import commit to better understand the changes.
> > > It contains some work from Eduardo for MingW packaging.
> > > Final patches are really minor.
> > 
> > Should I/we wait for Eduardo's review?
> > 
> 
> No idea what to suggest here. But surely I'd like some comments from
> him. Part of the implementation came from his job.

Ok, I'll try to give feedback later this week too.

> > > Frediano Ziglio (5):
> > >   build-sys: Import spec file from Fedora
> > >   build-sys: Provide spec file during build
> > >   build-sys: Allows spec file to build MingW packages
> > >   build-sys: Update URL in SPEC file
> > >   build-sys: Requires proper pkg-config for MingW
> > > 
> > >  Makefile.am            |   1 +
> > >  configure.ac           |   1 +
> > >  spice-protocol.spec.in | 224 +++++++++++++++++++++++++++++++++++++++++
> > 
> > Let's add to meson too?
> > 
> 
> I didn't though about. All SPEC files I started with are using autoconf
> and I never tested distribution with Meson (I did instead with spice-gtk).
> But it seems a bit of a follow up at the moment, it would require some
> additional scripts to make Meson distribute processed files and other changes.
> Not considering that if the SPEC at the end is using autoconf a Meson
> build would have to add generated "configure" and other relative files
> which is a bit odd and complex.

As follow up is fine, not a huge issue.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20191014/9a2089ae/attachment.sig>