[Spice-devel] [PATCH 3/3] win32/vd_agent: Optionally disable installation of x86 MSI on x64 system

Yuri Benditovich yuri.benditovich at daynix.com
Fri Oct 18 13:35:22 UTC 2019


Currently the MSI built for x86 system can be easily installed
on x64 system. When the script is processed by WIX this can be
prevented by passing '-dNoWOW=yes' to the WIX-candle.

Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>
---
 spice-vdagent.wxs.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/spice-vdagent.wxs.in b/spice-vdagent.wxs.in
index 7778c27..c451f13 100644
--- a/spice-vdagent.wxs.in
+++ b/spice-vdagent.wxs.in
@@ -31,6 +31,11 @@
       <UpgradeVersion Minimum="0.0.0" Maximum="$(var.Version)" IncludeMinimum="yes" IncludeMaximum="no" Property="OLDERVERSIONBEINGUPGRADED"/>
     </Upgrade>
     <Condition Message="Product already installed.">NOT NEWERVERSIONDETECTED</Condition>
+    <?if $(var.Win64) = no AND $(var.NoWOW) = yes ?>
+      <Condition Message="Error: 32-bit version of $(env.PRODUCT) can not be installed on 64-bit Windows.">
+          <![CDATA[Not VersionNT64]]>
+      </Condition>
+    <?endif?>
     <InstallExecuteSequence>
       <RemoveExistingProducts After="InstallFinalize"/>
     </InstallExecuteSequence>
-- 
2.17.1



More information about the Spice-devel mailing list