[Spice-devel] [PATCH spice-server v2 1/7] smart-channel-client: Remove spicec client reference from comment

Victor Toso victortoso at redhat.com
Mon Oct 21 08:01:13 UTC 2019


Hi,

On Mon, Oct 14, 2019 at 10:22:11AM +0100, Frediano Ziglio wrote:
> spicec is an obsolete client.

Should be fine to remove the other last referece (that my grep
could find) in this commit too?

server/red-channel-client.c:1187:     * after spicec disconnect
(but not with spice-gtk) repeatedly. */

> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  server/smartcard-channel-client.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/server/smartcard-channel-client.c b/server/smartcard-channel-client.c
> index 43df902f5..da472a2a7 100644
> --- a/server/smartcard-channel-client.c
> +++ b/server/smartcard-channel-client.c
> @@ -252,8 +252,7 @@ bool smartcard_channel_client_handle_message(RedChannelClient *rcc,
>      SmartCardChannelClient *scc = SMARTCARD_CHANNEL_CLIENT(rcc);
>  
>      if (type != SPICE_MSGC_SMARTCARD_DATA) {
> -        /* Handles seamless migration protocol. Also handles ack's,
> -         * spicy sends them while spicec does not */
> +        /* Handles seamless migration protocol. Also handles ack's */
>          return red_channel_client_handle_message(rcc, type, size, message);
>      }
>  
> -- 
> 2.21.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20191021/9dd96160/attachment.sig>


More information about the Spice-devel mailing list